Loki Prometheus mixin: templatize cluster label #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
|
|
|
@hervenicol can you do |
|
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0.3%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
- logql -0.4%
+ loki 0% |
Oops. Thanks for the tip @kavirajk , will know for future PRs. |
kavirajk
added a commit
that referenced
this pull request
Jun 13, 2022
4 tasks
dannykopping
pushed a commit
that referenced
this pull request
Jun 14, 2022
* fix formating * re-apply #6353 * promtail-mixin: gitignore vendor/ * promtail-mixin: support for config * mixins: improve config files * re-trigger build Co-authored-by: Herve Nicol <12008875+hervenicol@users.noreply.github.com>
JordanRushing
pushed a commit
to JordanRushing/loki
that referenced
this pull request
Jun 17, 2022
* Revert "Loki Prometheus mixin: templatize cluster label (grafana#6353)" This reverts commit 459036f. * Replace `loki-mixin` dependency to working commit. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> (cherry picked from commit 666bac2)
JordanRushing
added a commit
that referenced
this pull request
Jun 17, 2022
* Backport memberlist dependency version pin to k102 Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Revert "Loki Prometheus mixin: templatize cluster label" (#6377) * Revert "Loki Prometheus mixin: templatize cluster label (#6353)" This reverts commit 459036f. * Replace `loki-mixin` dependency to working commit. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> (cherry picked from commit 666bac2) Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
grafanabot
pushed a commit
that referenced
this pull request
Jun 24, 2022
* Backport memberlist dependency version pin to k102 Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Revert "Loki Prometheus mixin: templatize cluster label" (#6377) * Revert "Loki Prometheus mixin: templatize cluster label (#6353)" This reverts commit 459036f. * Replace `loki-mixin` dependency to working commit. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> (cherry picked from commit 666bac2) Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com> (cherry picked from commit 372961d)
vlad-diachenko
pushed a commit
that referenced
this pull request
Jun 24, 2022
* Backport memberlist dependency version pin to k102 Signed-off-by: JordanRushing <rushing.jordan@gmail.com> * Revert "Loki Prometheus mixin: templatize cluster label" (#6377) * Revert "Loki Prometheus mixin: templatize cluster label (#6353)" This reverts commit 459036f. * Replace `loki-mixin` dependency to working commit. Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com> (cherry picked from commit 666bac2) Co-authored-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com> (cherry picked from commit 372961d) Co-authored-by: JordanRushing <rushing.jordan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #6352
Special notes for your reviewer:
Checklist
config.libsonnetact as documentation.CHANGELOG.md.docs/sources/upgrading/_index.md